linux-kernel - Re: 转发: [PATCH] usb: serial: update CH34x driver in drivers/usb/serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 24 Jun 2016 08:09:51 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	WCH Tech Group <tech@...chiphead.com>
Cc:	johan@...nel.org, konstantin.shkolnyy@...il.com,
	pberger@...mson.com, david.ward@...mit.edu, m.othacehe@...il.com,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: 转发: [PATCH] usb: serial:
 update CH34x driver in drivers/usb/serial

On Fri, Jun 24, 2016 at 01:42:24PM +0800, WCH Tech Group wrote:
> 	There are several reasons why we decided to revoke the old one after
> communicating with the author of 
> ch341.c (Frank A Kingswood <frank@...gswood-consulting.co.uk>), first of all
> we want the driver to support both ch341 and
> ch340 chips, so we changed the driver name from "ch341.c" to "ch34x.c",

No need to rename the driver to support multiple chips.  Keep it the
same name, and just add the new device support.  That's how we do it for
lots and lots of Linux drivers, the name doesn't really matter that
much (look at the option.c driver for one such example.)

> secondly the new driver and old one are coded
> by different authors, in fact there's no connection between them.

Ok, but the functionality is the same, so please just fix up the
existing driver to add support for the new device, and fix any existing
bugs.

In Linux you don't get to just delete a working driver, you have to
evolve code over time, sending patches that do one logical thing at a
time so that people can properly review them.  Your patch is not how
this is supposed to happen at all.

So please just break up your changes into small logical ones, and send a
series of patches adding the new device support and fix up any known
bugs.

After that is all done, if you _really_ want to rename the driver, then
we can discuss that, but first do the work to evolve the driver, as that
is much more difficult.

thanks,

greg k-h