linux-kernel - Re: [PATCH v3 3/4] dm: add infrastructure for DAX support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1466782822.3504.391.camel@hpe.com>
Date:	Fri, 24 Jun 2016 15:40:24 +0000
From:	"Kani, Toshimitsu" <toshi.kani@....com>
To:	"snitzer@...hat.com" <snitzer@...hat.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-nvdimm@...1.01.org" <linux-nvdimm@...1.01.org>,
	"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	"axboe@...nel.dk" <axboe@...nel.dk>,
	"ross.zwisler@...ux.intel.com" <ross.zwisler@...ux.intel.com>,
	"dm-devel@...hat.com" <dm-devel@...hat.com>,
	"yigal@...xistor.com" <yigal@...xistor.com>
Subject: Re: [PATCH v3 3/4] dm: add infrastructure for DAX support

On Thu, 2016-06-23 at 21:49 -0400, Mike Snitzer wrote:
> On Thu, Jun 23 2016 at  7:36pm -0400,
> Kani, Toshimitsu <toshi.kani@....com> wrote:
 :
> > Thanks for the update.  I have a question about the above change.  Targets
> > may have their own parameters.  For instance, dm-stripe has 'chunk_size',
> > which is checked in stripe_ctr().  DAX adds additional restriction that
> > chunk_size needs to be aligned by page size.  So, I think we need to keep
> > target responsible to verify if DAX can be supported.  What do you think?
>
> We've never had to concern the dm-stripe target with hardware
> specific chunk_size validation.  The user is able to specify the
> chunk_size via lvm2's lvcreate -I argument.  Yes this gives users enough
> rope to hang themselves but it is very easy to configure a dm-stripe
> device with the appropriate chunk size (PAGE_SIZE) from userspace.
> 
> But lvm2 could even be trained to make sure the chunk_size is a factor
> of physical_block_size (PAGE_SIZE in the case of pmem) if the underlying
> devices export queue/dax=1

lvcreate -I only allows multiple of page size, so we are OK with lvm2.  I was
wondering if the check in lvm2 is enough.  Are there any other tools that may
be used to configure stripe size?  Can we trust userspace on this?

Thanks,
-Toshi