[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160624202539.GE8399@intel.com>
Date: Fri, 24 Jun 2016 23:25:39 +0300
From: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To: Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc: Peter Huewe <peterhuewe@....de>,
linux-security-module@...r.kernel.org,
Stefan Berger <stefanb@...ux.vnet.ibm.com>,
Marcel Selhorst <tpmdd@...horst.net>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@...ts.sourceforge.net>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/5] tpm: unify tpm_gen_interrupt()
On Fri, Jun 24, 2016 at 01:30:24PM -0600, Jason Gunthorpe wrote:
> On Fri, Jun 17, 2016 at 11:10:43PM +0200, Jarkko Sakkinen wrote:
> > extern int tpm_get_timeouts(struct tpm_chip *);
> > -extern void tpm_gen_interrupt(struct tpm_chip *);
> > +void tpm_gen_interrupt(struct tpm_chip *);
>
> Dropping the argument name is not the kernel standard, if these lines
> are going to be churned they may as well be churned to the standard.
>
> FWIW, all the extern's should be dropped too.
Thanks for pointin these out. And yes, since this is mostly a cleanup
series, adding a patch that would clean up those unnecessary externs
would make sense. I'll send a revised version with your suggestions.
> Jason
/Jarkko
Powered by blists - more mailing lists