linux-kernel - Re: [PATCH] usb: serial: update CH34x driver in drivers/usb/serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160624023913.GA30063@kroah.com>
Date:	Thu, 23 Jun 2016 19:39:13 -0700
From:	Greg KH <greg@...ah.com>
To:	tech@...chiphead.com
Cc:	johan@...nel.org, gregkh@...uxfoundation.rog,
	konstantin.shkolnyy@...il.com, pberger@...mson.com,
	david.ward@...mit.edu, m.othacehe@...il.com,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb: serial: update CH34x driver in drivers/usb/serial

On Thu, Jun 23, 2016 at 06:47:54PM -0700, tech@...chiphead.com wrote:
> The old driver for usb-serial chips ch34x which submitted by kernel volunteer
> Frank A Kingswood <frank@...gswood-consulting.co.uk> is too old to use, and the
> driver has bugs when receiving chracters, thus after communicating with the author 
> we decide to revoke the old driver ch341.c and submit the new one ch34x.c.

"revoke"?  Why not just fix the bugs in the existing one instead?  That
would be a much smaller patch, and much easier to review.

> Add the relevant details to Documentation/usb/usb-serial.txt.
> Change the relevant files Kconfig and Makefile in drivers/usb/serial.
> 
> Signed-off-by: WCH Tech Group <tech@...chiphead.com>

This has to be a person, it can not be a company, or any other anonymous
email address, sorry.  Same with your "From:" address.

thanks,

greg k-h