linux-kernel - Re: [PATCH] mm/compaction: remove unnecessary order check in try_to_compact

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160624135839.d27727e6ba9ab4b4aff0cc32@linux-foundation.org>
Date:	Fri, 24 Jun 2016 13:58:39 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Anshuman Khandual <khandual@...ux.vnet.ibm.com>
Cc:	Ganesh Mahendran <opensource.ganesh@...il.com>, vbabka@...e.cz,
	iamjoonsoo.kim@....com, mhocko@...e.com, mina86@...a86.com,
	minchan@...nel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/compaction: remove unnecessary order check in
 try_to_compact_pages()

On Wed, 15 Jun 2016 14:16:20 +0530 Anshuman Khandual <khandual@...ux.vnet.ibm.com> wrote:

> On 06/15/2016 12:22 PM, Ganesh Mahendran wrote:
> > The caller __alloc_pages_direct_compact() already check (order == 0).
> > So no need to check again.
> 
> Yeah, the caller (__alloc_pages_direct_compact) checks if the order of
> allocation is 0. But we can remove it there and keep it in here as this
> is the actual entry point for direct page compaction.

I think the check in __alloc_pages_direct_compact() is OK - it's a bit
silly to do a (small) bunch of additional work in
__alloc_pages_direct_compact() when orer==0.