[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAGRGNgWU88xwRRA3Q9tnKc79zq1TfJw6iTB10c3TOmmdH=L3qA@mail.gmail.com>
Date: Fri, 24 Jun 2016 12:53:19 +1000
From: Julian Calaby <julian.calaby@...il.com>
To: megous@...ous.com
Cc: Linux Sunxi <dev@...ux-sunxi.org>,
"Mailing List, Arm" <linux-arm-kernel@...ts.infradead.org>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Russell King <linux@...linux.org.uk>,
Maxime Ripard <maxime.ripard@...e-electrons.com>,
Chen-Yu Tsai <wens@...e.org>,
Emilio López <emilio@...pez.com.ar>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...eaurora.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>,
"open list:COMMON CLK FRAMEWORK" <linux-clk@...r.kernel.org>
Subject: Re: [linux-sunxi] [PATCH 11/14] ARM: sun8i: clk: Add clk-factor rate
application method
Hi Ondrej,
On Fri, Jun 24, 2016 at 5:21 AM, <megous@...ous.com> wrote:
> From: Ondrej Jirman <megous@...ous.com>
>
> PLL1 on H3 requires special factors application algorithm,
> when the rate is changed. This algorithm was extracted
> from the arisc code that handles frequency scaling
> in the BSP kernel.
>
> This commit adds optional apply function to
> struct factors_data, that can implement non-trivial
> factors application method, when necessary.
>
> Also struct clk_factors_config is extended with position
> of the PLL lock flag.
>
> Signed-off-by: Ondrej Jirman <megous@...ous.com>
> ---
> arch/arm/boot/dts/sun8i-h3.dtsi | 2 +-
> drivers/clk/sunxi/clk-factors.c | 34 +++++++++----------
> drivers/clk/sunxi/clk-factors.h | 12 +++++++
> drivers/clk/sunxi/clk-sunxi.c | 72 +++++++++++++++++++++++++++++++++++++++--
> 4 files changed, 98 insertions(+), 22 deletions(-)
Shouldn't the .dtsi changes be in a separate patch?
Thanks,
--
Julian Calaby
Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/
Powered by blists - more mailing lists