linux-kernel - Re: [RESEND PATCH v2 1/2] staging: iio: accel: fix error check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92672797-02a4-472a-241f-b3d437cc97f1@kernel.org>
Date:	Sun, 26 Jun 2016 15:58:45 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Luis de Bethencourt <luisbg@....samsung.com>,
	linux-kernel@...r.kernel.org
Cc:	gregkh@...uxfoundation.org, knaack.h@....de, lars@...afoo.de,
	pmeerw@...erw.net, ciorneiioana@...il.com, afd@...com,
	janani.rvchndrn@...il.com, linux-iio@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: Re: [RESEND PATCH v2 1/2] staging: iio: accel: fix error check

On 22/06/16 20:43, Luis de Bethencourt wrote:
> sca3000_read_ctrl_reg() returns a negative number on failure, check for
> this instead of zero.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> Reviewed-by: Andrew F. Davis <afd@...com>
> Reviewed-by: Jonathan Cameron <jic23@...nel.org>

Note that, like any tag, reviewed-by tags must be provided by the person
who did the review.  It's nice to acknowledge reviewers, but there is
a certain "I'm happy with the result of my review" that is associated
with a reviewed-by tag.

Marked for stable and applied to the fixes-togreg branch of iio.git

Thanks,

Jonathan

> ---
>  drivers/staging/iio/accel/sca3000_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c
> index a8f533a..ec12181 100644
> --- a/drivers/staging/iio/accel/sca3000_core.c
> +++ b/drivers/staging/iio/accel/sca3000_core.c
> @@ -594,7 +594,7 @@ static ssize_t sca3000_read_frequency(struct device *dev,
>  		goto error_ret_mut;
>  	ret = sca3000_read_ctrl_reg(st, SCA3000_REG_CTRL_SEL_OUT_CTRL);
>  	mutex_unlock(&st->lock);
> -	if (ret)
> +	if (ret < 0)
>  		goto error_ret;
>  	val = ret;
>  	if (base_freq > 0)
>