linux-kernel - Re: [PATCH V2 13/63] clocksource/drivers/bcm2835_timer: Convert init function to return error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87mvm8myqt.fsf@eliezer.anholt.net>
Date:	Sat, 25 Jun 2016 20:10:18 -0700
From:	Eric Anholt <eric@...olt.net>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	daniel.lezcano@...aro.org, tglx@...utronix.de
Cc:	linux-kernel@...r.kernel.org,
	Stephen Warren <swarren@...dotorg.org>,
	Lee Jones <lee@...nel.org>,
	"moderated list\:BROADCOM BCM2835..." 
	<linux-rpi-kernel@...ts.infradead.org>,
	"moderated list\:BROADCOM BCM2835..." 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V2 13/63] clocksource/drivers/bcm2835_timer: Convert init function to return error

Daniel Lezcano <daniel.lezcano@...aro.org> writes:

> The init functions do not return any error. They behave as the following:
>
>  - panic, thus leading to a kernel crash while another timer may work and
>    make the system boot up correctly
>
>  or
>
>  - print an error and let the caller unaware if the state of the system
>
> Change that by converting the init functions to return an error conforming
> to the CLOCKSOURCE_OF_RET prototype.
>
> Proper error handling (rollback, errno value) will be changed later case
> by case, thus this change just return back an error or success in the init
> function.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>

For the bcm2835 changes here and in 63/63:

Acked-by: Eric Anholt <eric@...olt.net>

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)