linux-kernel - Re: [PATCH 1/2] net: ethernet: ethoc: use phydev from struct net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160627063258.GH28466@distanz.ch>
Date:	Mon, 27 Jun 2016 08:32:59 +0200
From:	Tobias Klauser <tklauser@...tanz.ch>
To:	Philippe Reynes <tremyfr@...il.com>
Cc:	davem@...emloft.net, andrew@...n.ch, colin.king@...onical.com,
	f.fainelli@...il.com, jcmvbkbc@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] net: ethernet: ethoc: use phydev from struct
 net_device

On 2016-06-25 at 16:33:41 +0200, Philippe Reynes <tremyfr@...il.com> wrote:
> The private structure contain a pointer to phydev, but the structure
> net_device already contain such pointer. So we can remove the pointer
> phy in the private structure, and update the driver to use the
> one contained in struct net_device.

In that case the phy member should also be removed from the definition
of private struct ethoc in the same patch.

Otherwise the patch looks good to me.