linux-kernel - Re: [PATCH][RFC] cpufreq: Avoid warning during resume by return EAGAIN if cpufreq is unavailable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160627072027.GC3341@vireshk-i7>
Date:	Mon, 27 Jun 2016 12:50:27 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Chen Yu <yu.c.chen@...el.com>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH][RFC] cpufreq: Avoid warning during resume by return
 EAGAIN if cpufreq is unavailable

On 27-06-16, 03:12, Rafael J. Wysocki wrote:
> ---
>  drivers/cpufreq/cpufreq.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> Index: linux-pm/drivers/cpufreq/cpufreq.c
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/cpufreq.c
> +++ linux-pm/drivers/cpufreq/cpufreq.c
> @@ -1544,9 +1544,6 @@ static unsigned int cpufreq_update_curre
>  {
>  	unsigned int new_freq;
>  
> -	if (cpufreq_suspended)
> -		return 0;
> -
>  	new_freq = cpufreq_driver->get(policy->cpu);
>  	if (!new_freq)
>  		return 0;
> @@ -2280,6 +2277,10 @@ int cpufreq_update_policy(unsigned int c
>  	 * -> ask driver for current freq and notify governors about a change
>  	 */
>  	if (cpufreq_driver->get && !cpufreq_driver->setpolicy) {
> +		if (cpufreq_suspended) {
> +			ret = -EAGAIN;
> +			goto unlock;
> +		}
>  		new_policy.cur = cpufreq_update_current_freq(policy);
>  		if (WARN_ON(!new_policy.cur)) {
>  			ret = -EIO;

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
-- 
viresh