linux-kernel - Re: [PATCH 20/27] [AARCH64] Make lp64 and ilp32 directories.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5629692.f1OMxVMDuj@wuerfel>
Date:	Mon, 27 Jun 2016 10:03:04 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Andreas Schwab <schwab@...e.de>
Cc:	Yury Norov <ynorov@...iumnetworks.com>, libc-alpha@...rceware.org,
	linux-kernel@...r.kernel.org, catalin.marinas@....com,
	marcus.shawcroft@....com, philb@....org, davem@...emloft.net,
	szabolcs.nagy@....com, maxim.kuvyrkov@...aro.org,
	joseph@...esourcery.com, pinskia@...il.com,
	Andrew Pinski <apinski@...ium.com>
Subject: Re: [PATCH 20/27] [AARCH64] Make lp64 and ilp32 directories.

On Monday, June 27, 2016 9:56:13 AM CEST Andreas Schwab wrote:
> Yury Norov <ynorov@...iumnetworks.com> writes:
> 
> > diff --git a/sysdeps/unix/sysv/linux/aarch64/bits/fcntl.h b/sysdeps/unix/sysv/linux/aarch64/bits/fcntl.h
> > index 658f696..7dcbe65 100644
> > --- a/sysdeps/unix/sysv/linux/aarch64/bits/fcntl.h
> > +++ b/sysdeps/unix/sysv/linux/aarch64/bits/fcntl.h
> > @@ -25,7 +25,11 @@
> >  #define __O_NOFOLLOW 0100000
> >  #define __O_DIRECT   0200000
> >  
> > -#define __O_LARGEFILE        0
> > +#ifdef __ILP32__
> > +# define __O_LARGEFILE       0400000
> > +#else
> > +# define __O_LARGEFILE       0
> > +#endif
> 
> Is there any point in defining O_LARGEFILE to non-zero if the kernel is
> enforcing it anyway?

The kernel might want to return -EINVAL for undefined flags. I'm not
sure if we want to do that here, but it would seem like a correct
return code.

	Arnd