linux-kernel - Re: [PATCH] i2c: tegra: Correct error path in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5770F2CB.2090109@nvidia.com>
Date:	Mon, 27 Jun 2016 15:02:59 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Jon Hunter <jonathanh@...dia.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Alexandre Courbot <gnurou@...il.com>
CC:	Shardar Shariff Md <smohammed@...dia.com>,
	<linux-i2c@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: tegra: Correct error path in probe


On Monday 27 June 2016 02:58 PM, Jon Hunter wrote:
> Hi all,
>
> On 14/06/16 21:26, Jon Hunter wrote:
>> @@ -912,7 +912,7 @@ static int tegra_i2c_probe(struct platform_device *pdev)
>>   	ret = tegra_i2c_init(i2c_dev);
>>   	if (ret) {
>>   		dev_err(&pdev->dev, "Failed to initialize i2c controller");
>> -		goto unprepare_div_clk;
>> +		goto disable_div_clk;
>>   	}
>>

Yes, this looks correct.

Acked-by: Laxman Dewangan <ldewangan@...dia.com>