linux-kernel - Re: [tpmdd-devel] [PATCH] tpm: use devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160627140445.GA1233@intel.com>
Date:	Mon, 27 Jun 2016 17:04:45 +0300
From:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org
Subject: Re: [tpmdd-devel] [PATCH] tpm: use devm_add_action_or_reset

On Thu, Jun 16, 2016 at 10:28:23PM +0200, Jarkko Sakkinen wrote:
> On Sun, Jun 12, 2016 at 03:05:29PM +0100, Sudip Mukherjee wrote:
> > If devm_add_action() fails we are explicitly calling put_device() to
> > free the resources allocated. Lets use the helper
> > devm_add_action_or_reset() and return directly in case of error, as we
> > know that the cleanup function has been already called by the helper if
> > there was any error.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
> 
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>

Applied to master.

/Jarkko