linux-kernel - Re: BUG?: kernel does not (re)set irq smp_affinity to reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 27 Jun 2016 15:54:46 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	Hans de Goede <hdegoede@...hat.com>
Cc:	Russell King - ARM Linux <linux@...linux.org.uk>,
	Marc Zyngier <marc.zyngier@....com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Chen-Yu Tsai <wens@...e.org>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: BUG?: kernel does not (re)set irq smp_affinity to reboot_cpu

On Mon, Jun 27, 2016 at 02:53:16PM +0200, Hans de Goede wrote:
> Note this does not mean that all pm_power_off implementations
> are going to be happy with machine_power_off leaving irqs
> enabled, I would esp. expect the efi and psci implementations
> to potentially be unhappy about this. See below for a proposal
> to deal with this.

Neither PSCI nor EFI care either way about interrupts.

PSCI makes synchronous HVC/SMC calls to a higher exception level, and
can be safely called with interrupts enabled or disabled.

EFI's ResetSystem (which backs pm_power_off) can be called with
interrupts enabled or disabled, so long as there is not a clashing call
in progress already (see 7.1 "Runtime Services Rules and Restrictions")
in the EFI 2.6 spec.

Thanks,
Mark.