linux-kernel - Re: [PATCH] [perf]: update makefile message for installing required libs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Jun 2016 12:34:38 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	neerajbadlani@...il.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [perf]: update makefile message for installing required
 libs

Em Mon, Jun 27, 2016 at 06:59:57AM -0700, neerajbadlani@...il.com escreveu:
> From: Neeraj Badlani <neerajbadlani@...il.com>
> 
> In case of missing library (libslang), give hint to install library (libslang2-dev)
> Since libslang-dev is not provided by Ubuntu's apt-package
> 
> Signed-off-by: Neeraj Badlani <neerajbadlani@...il.com>
> ---
>  tools/perf/config/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 5ad0255..e57d4d7 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -437,7 +437,7 @@ endif
>  
>  ifndef NO_SLANG
>    ifneq ($(feature-libslang), 1)
> -    msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev);
> +    msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev or libslang2-dev);

Too many 'or', I'll apply it as:

+    msg := $(warning slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev);

Thanks,

- Arnaldo

>      NO_SLANG := 1
>    else
>      # Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h
> -- 
> 2.7.4