linux-kernel - Re: [PATCH 1/1] regulator: max77620: check for valid regulator info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160627161405.GA17217@sirena.org.uk>
Date:	Mon, 27 Jun 2016 17:14:05 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Venkat Reddy Talla <vreddytalla@...dia.com>
Cc:	lgirdwood@...il.com, linux-kernel@...r.kernel.org,
	ldewangan@...dia.com
Subject: Re: [PATCH 1/1] regulator: max77620: check for valid regulator info

On Mon, Jun 27, 2016 at 05:13:44PM +0530, Venkat Reddy Talla wrote:
> Check for valid regulator information data before
> configuring FPS source and FPS power up/down
> period to avoid NULL pointer exception if entries for
> PMIC regulators not provided through device tree.

This sounds like it's papering over a bug in the driver - the driver
should be able to instantiate without anything beyond the registration
of the device.  What's the driver relying on from the DT?

> SD4 regulator is not supported by MAX77620 PMIC, removing
> SD4 entry from regulator information list.

This appears to be a separate change to the above and should be a
separate patch.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)