linux-kernel - Re: [PATCH v2 2/3] intel_pstate: add __init/__initdata marker to some functions/variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1467048417.8970.80.camel@linux.intel.com>
Date:	Mon, 27 Jun 2016 10:26:57 -0700
From:	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:	Jisheng Zhang <jszhang@...vell.com>, lenb@...nel.org,
	rjw@...ysocki.net, viresh.kumar@...aro.org
Cc:	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] intel_pstate: add __init/__initdata marker to
 some functions/variables

On Mon, 2016-06-27 at 18:07 +0800, Jisheng Zhang wrote:
> These functions/variables are not needed after booting, so mark them
> as __init or __initdata.
> 
> Signed-off-by: Jisheng Zhang <jszhang@...vell.com>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> ---
>  drivers/cpufreq/intel_pstate.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c
> b/drivers/cpufreq/intel_pstate.c
> index 44099e9..861bcba 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1355,7 +1355,7 @@ static const struct x86_cpu_id
> intel_pstate_cpu_ids[] = {
>  };
>  MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
>  
> -static const struct x86_cpu_id intel_pstate_cpu_oob_ids[] = {
> +static const struct x86_cpu_id intel_pstate_cpu_oob_ids[]
> __initconst = {
>  	ICPU(0x56, core_params),
>  	{}
>  };
> @@ -1577,9 +1577,9 @@ static struct cpufreq_driver
> intel_pstate_driver = {
>  static int no_load __initdata;
>  static int no_hwp __initdata;
>  static int hwp_only __initdata;
> -static unsigned int force_load;
> +static unsigned int force_load __initdata;
>  
> -static int intel_pstate_msrs_not_valid(void)
> +static int __init intel_pstate_msrs_not_valid(void)
>  {
>  	if (!pstate_funcs.get_max() ||
>  	    !pstate_funcs.get_min() ||
> @@ -1589,7 +1589,7 @@ static int intel_pstate_msrs_not_valid(void)
>  	return 0;
>  }
>  
> -static void copy_pid_params(struct pstate_adjust_policy *policy)
> +static void __init copy_pid_params(struct pstate_adjust_policy
> *policy)
>  {
>  	pid_params.sample_rate_ms = policy->sample_rate_ms;
>  	pid_params.sample_rate_ns = pid_params.sample_rate_ms *
> NSEC_PER_MSEC;
> @@ -1600,7 +1600,7 @@ static void copy_pid_params(struct
> pstate_adjust_policy *policy)
>  	pid_params.setpoint = policy->setpoint;
>  }
>  
> -static void copy_cpu_funcs(struct pstate_funcs *funcs)
> +static void __init copy_cpu_funcs(struct pstate_funcs *funcs)
>  {
>  	pstate_funcs.get_max   = funcs->get_max;
>  	pstate_funcs.get_max_physical = funcs->get_max_physical;
> @@ -1615,7 +1615,7 @@ static void copy_cpu_funcs(struct pstate_funcs
> *funcs)
>  
>  #ifdef CONFIG_ACPI
>  
> -static bool intel_pstate_no_acpi_pss(void)
> +static bool __init intel_pstate_no_acpi_pss(void)
>  {
>  	int i;
>  
> @@ -1644,7 +1644,7 @@ static bool intel_pstate_no_acpi_pss(void)
>  	return true;
>  }
>  
> -static bool intel_pstate_has_acpi_ppc(void)
> +static bool __init intel_pstate_has_acpi_ppc(void)
>  {
>  	int i;
>  
> @@ -1672,7 +1672,7 @@ struct hw_vendor_info {
>  };
>  
>  /* Hardware vendor-specific info that has its own power management
> modes */
> -static struct hw_vendor_info vendor_info[] = {
> +static struct hw_vendor_info vendor_info[] __initdata = {
>  	{1, "HP    ", "ProLiant", PSS},
>  	{1, "ORACLE", "X4-2    ", PPC},
>  	{1, "ORACLE", "X4-2L   ", PPC},
> @@ -1691,7 +1691,7 @@ static struct hw_vendor_info vendor_info[] = {
>  	{0, "", ""},
>  };
>  
> -static bool intel_pstate_platform_pwr_mgmt_exists(void)
> +static bool __init intel_pstate_platform_pwr_mgmt_exists(void)
>  {
>  	struct acpi_table_header hdr;
>  	struct hw_vendor_info *v_info;