linux-kernel - Re: [RFC 1/6] perf: Remove unused hist_entry_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160627173505.GB27027@kernel.org>
Date:	Mon, 27 Jun 2016 14:35:05 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, anton@...abs.org, mpe@...erman.id.au,
	ananth@...ibm.com, dja@...ens.net
Subject: Re: [RFC 1/6] perf: Remove unused hist_entry__annotate function

Em Fri, Jun 24, 2016 at 05:23:55PM +0530, Ravi Bangoria escreveu:
> hist_entry__annotate looks part of API but I don't find any caller
> of this function. Removing it.

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
> ---
>  tools/perf/util/annotate.c | 5 -----
>  tools/perf/util/annotate.h | 2 --
>  2 files changed, 7 deletions(-)
> 
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index 7e5a1e8..b2c7ae4 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -1676,11 +1676,6 @@ int symbol__tty_annotate(struct symbol *sym, struct map *map,
>  	return 0;
>  }
>  
> -int hist_entry__annotate(struct hist_entry *he, size_t privsize)
> -{
> -	return symbol__annotate(he->ms.sym, he->ms.map, privsize);
> -}
> -
>  bool ui__has_annotation(void)
>  {
>  	return use_browser == 1 && perf_hpp_list.sym;
> diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
> index 9241f8c..82f3781 100644
> --- a/tools/perf/util/annotate.h
> +++ b/tools/perf/util/annotate.h
> @@ -156,8 +156,6 @@ void symbol__annotate_zero_histograms(struct symbol *sym);
>  
>  int symbol__annotate(struct symbol *sym, struct map *map, size_t privsize);
>  
> -int hist_entry__annotate(struct hist_entry *he, size_t privsize);
> -
>  int symbol__annotate_init(struct map *map, struct symbol *sym);
>  int symbol__annotate_printf(struct symbol *sym, struct map *map,
>  			    struct perf_evsel *evsel, bool full_paths,
> -- 
> 2.5.5