linux-kernel - Re: [PATCH 2/2] mm: workingset: printk missing log level, use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1467000090.1847.81.camel@perches.com>
Date:	Sun, 26 Jun 2016 21:01:30 -0700
From:	Joe Perches <joe@...ches.com>
To:	Anton Blanchard <anton@...abs.org>, akpm@...ux-foundation.org,
	oleg@...hat.com, hannes@...xchg.org, mingo@...nel.org,
	fweisbec@...il.com, jkosina@...e.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mm: workingset: printk missing log level, use
 pr_info()

On Mon, 2016-06-27 at 09:01 +1000, Anton Blanchard wrote:
> commit 612e44939c3c ("mm: workingset: eviction buckets for bigmem/lowbit
> machines") added a printk without a log level. Quieten it by using
> pr_info().
[]
> diff --git a/mm/workingset.c b/mm/workingset.c
[]
> @@ -491,7 +491,7 @@ static int __init workingset_init(void)
>  	max_order = fls_long(totalram_pages - 1);
>  	if (max_order > timestamp_bits)
>  		bucket_order = max_order - timestamp_bits;
> -	printk("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n",
> +	pr_info("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n",
>  	       timestamp_bits, max_order, bucket_order);

Because it's possible to have more printks added,
perhaps it's better to add

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

before any #include and remove the "workingset: "
prefix here.