linux-kernel - Freeing alternatives sections after module init?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Jun 2016 17:07:27 -0400
From:	Jessica Yu <jeyu@...hat.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	linux-kernel@...r.kernel.org
Subject: Freeing alternatives sections after module init?

Hi Rusty,

I noticed that the module loader keeps .altinstructions and
.altinstr_replacement (which are normally freed after kernel init) in
core memory after module init, so these sections are never freed for
modules.

In fact, the module loader seems to keep a number of sections normally
marked between __init_begin and __init_end (which are then freed in
free_initmem()) in module core memory, for example on x86, there's
also .parainstructions and .altinstr_aux.

I was just wondering if this discrepancy was intentional :-)
Shouldn't these sections be freed after init? Though it probably
doesn't hurt to keep some of these sections in memory,
.altinstr_replacement is (for whatever reason) an executable section,
and is technically not needed anymore after apply_alternatives()
copies the replacement instructions, so it might be good to free it.

Thanks,
Jessica