linux-kernel - Re: [PATCH v2 2/3] spi: of: allow instantiating slaves without a driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Jun 2016 22:14:59 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Michal Suchanek <hramrach@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org
Subject: Re: [PATCH v2 2/3] spi: of: allow instantiating slaves without a
 driver

On Mon, Jun 27, 2016 at 09:02:31PM +0200, Michal Suchanek wrote:

> SPI slave devices are not created when looking up driver for the slave
> fails. Create a device anyway so it can be manually bound to a driver.

That's not what of_modalias_node() does, of_modalias_node() just mangles
a compatible string into a format for consumption by modutils.  It makes
no effort to find a driver in doing this, it just does a simple string
transformation on the compatible.

> This allows manually binding a driver to slave devices for which the
> driver specified by compatible is not available of for which no driver
> is specified at all. Drivers like spidev or m25p80 that require no
> configuratiom can be bound to such node.

As ever spidev should never appear directly in a DT because it is not a
description of hardware, the DT should describe whatever device is there
and then we need to work out in Linux how to bind spidev to it if that's
what we want to do.  m25p80 does represent real hardware and that
hardware should be described, for example by using the jedec,spi-nor
compatible which says that a non-specific JEDEC enumerable flash is
present.

> Since this allows slave DT nodes without specifying a slave driver make
> speed also optional. It makes no sense to specify speed when the device
> is not specified. The value is only advisory anyway and the slave
> driver can try to set arbitrary transfer speed.

This appears to be at best marginally related to the rest of the patch.
That means that it should be a separate patch.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)