linux-kernel - Re: [PATCH v2 3/8] Input: synaptics-rmi4: Add dribble and palm gesture parameters to device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Jun 2016 15:56:06 -0500
From:	Rob Herring <robh@...nel.org>
To:	Andrew Duggan <aduggan@...aptics.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Vincent Huang <vincent.huang@...synaptics.com>,
	Nick Dyer <nick.dyer@...ev.co.uk>, devicetree@...r.kernel.org,
	Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v2 3/8] Input: synaptics-rmi4: Add dribble and palm
 gesture parameters to device tree

On Fri, Jun 24, 2016 at 05:18:37PM -0700, Andrew Duggan wrote:
> Signed-off-by: Andrew Duggan <aduggan@...aptics.com>
> ---
>  .../devicetree/bindings/input/rmi4/rmi_2d_sensor.txt          |  4 ++++
>  drivers/input/rmi4/rmi_2d_sensor.c                            | 11 +++++++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt b/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
> index f2c30c8..86cb8e3 100644
> --- a/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
> +++ b/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
> @@ -37,6 +37,10 @@ Optional Properties:
>  				disable reporing absolute position data.
>  - syna,rezero-wait-ms: Time in miliseconds to wait after issuing a rezero
>  				command.
> +- syna,dribble-enable: Enable reporting of dribble packets in the firmware.
> +- syna,dribble-disable: Disable reporting of dribble packets in the firmware.
> +- syna,palm-detect-enable: Enable reporting the palm detect gesture in the firmware.
> +- syna,palm-detect-disable: Disable reporting the palm detect gesture in the firmware.

No need for enable and disable. Make the common case be no property and 
the property is the opposite.

Rob