linux-kernel - Re: [PATCH v3 2/6] Documentation: dt: mtd: gpmi: document the clocks and clock-names in DT property

Open Source and information security mailing list archives

Message-ID: <CA+EcR21hRgt6veugwf8oasZkRD6DEeMtBXGoJa+Z-aY2eJwBRw@mail.gmail.com>
Date:	Tue, 28 Jun 2016 16:18:27 -0500
From:	Han Xu <xhnjupt@...il.com>
To:	Rob Herring <robh@...nel.org>
Cc:	Han Xu <han.xu@....com>, mark.rutland@....com,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	pawel.moll@....com, ijc+devicetree@...lion.org.uk,
	Richard Weinberger <richard@....at>,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	Kumar Gala <galak@...eaurora.org>,
	Brian Norris <computersforpeace@...il.com>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH v3 2/6] Documentation: dt: mtd: gpmi: document the clocks
 and clock-names in DT property

On Tue, Jun 28, 2016 at 3:55 PM, Rob Herring <robh@...nel.org> wrote:
> On Fri, Jun 24, 2016 at 04:40:07PM -0500, Han Xu wrote:
>> add the clocks and clock-names in DT property, gpmi-io clock is
>> mandatory for all platforms, but some platforms, such as i.MX6Q may
>> need more extra clocks for submodules. More details please refer to the
>> SoC reference manual.
>>
>> Signed-off-by: Han Xu <han.xu@....com>
>> ---
>>  Documentation/devicetree/bindings/mtd/gpmi-nand.txt | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/gpmi-nand.txt b/Documentation/devicetree/bindings/mtd/gpmi-nand.txt
>> index d02acaf..a2fd034 100644
>> --- a/Documentation/devicetree/bindings/mtd/gpmi-nand.txt
>> +++ b/Documentation/devicetree/bindings/mtd/gpmi-nand.txt
>> @@ -13,6 +13,13 @@ Required properties:
>>      and GPMI DMA channel ID.
>>      Refer to dma.txt and fsl-mxs-dma.txt for details.
>>    - dma-names: Must be "rx-tx".
>> +  - clocks : The clocks needed by the gpmi controller. This field varies
>> +    depends on the SoC design, "gpmi-io" is mandatory but some platforms may
>> +    need several extra clocks, such as i.MX6 series, which requires "gpmi_apb,
>> +    gpmi_bch, gpmi_bch_apb and per1_bch" for all submodules, while i.MX7 only
>> +    need gpmi_bch_apb. Please refer to the HW design manual.
>> +  - clock-names : the name of the clocks, please refer to the HW design
>> +    manual.
>
> No please list the names here (I assume what is above?). Also need to
> specify the order of the clocks. It would be clearest if you list things
> by exact compatible strings.

These are the exact clocks needed by i.MX6 and i.MX7. Order doesn't matter.

>
> Rob
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

-- 
Sincerely,

Han XU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives