linux-kernel - Re: [PATCH v3 2/2] remoteproc: qcom: Introduce WCNSS peripheral image loader

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160628212219.GG1190@tuxbot>
Date:	Tue, 28 Jun 2016 14:22:19 -0700
From:	Bjorn Andersson <bjorn.andersson@...aro.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Ohad Ben-Cohen <ohad@...ery.com>, devicetree@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
	linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	John Stultz <john.stultz@...aro.org>,
	Bjorn Andersson <bjorn.andersson@...ymobile.com>
Subject: Re: [PATCH v3 2/2] remoteproc: qcom: Introduce WCNSS peripheral
 image loader

On Tue 28 Jun 14:05 PDT 2016, Arnd Bergmann wrote:

> On Tuesday, June 28, 2016 1:58:26 PM CEST Bjorn Andersson wrote:
> > 
> > +config QCOM_WCNSS_PIL
> > +       tristate "Qualcomm WCNSS Peripheral Image Loader"
> > +       depends on OF && ARCH_QCOM
> > +       select QCOM_MDT_LOADER
> > +       select QCOM_SCM
> > +       select REMOTEPROC
> > +       help
> > +         Say y here to support the Peripherial Image Loader for the Qualcomm
> > +         Wireless Connectivity Subsystem.
> > +
> > 
> 
> 	"depends on QCOM_SMEM"
> 
> This showed up in Linux-next today and caused a build error:
> 
> drivers/remoteproc/built-in.o: In function `q6v5_fatal_interrupt':
> qcom_q6v5_pil.c:(.text+0x2428): undefined reference to `qcom_smem_get'
> drivers/remoteproc/built-in.o: In function `q6v5_wdog_interrupt':
> qcom_q6v5_pil.c:(.text+0x2498): undefined reference to `qcom_smem_get'
> 

I was convinced I had stubs for those, sorry for not making sure. I
amended rproc-next with this.

Thanks,
Bjorn