linux-kernel - Re: [PATCH 2/2] x86/acpi: Remove the repeated lapic address override entry parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13220110.pDtUHjvoJt@vostro.rjw.lan>
Date:	Tue, 28 Jun 2016 03:25:57 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Baoquan He <bhe@...hat.com>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org,
	Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...e.de>,
	Andy Lutomirski <luto@...nel.org>, Shaohua Li <shli@...com>,
	Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>,
	Juergen Gross <jgross@...e.com>,
	Joerg Roedel <jroedel@...e.de>, Dave Young <dyoung@...hat.com>,
	Lv Zheng <lv.zheng@...el.com>, Toshi Kani <toshi.kani@....com>,
	Mark Salter <msalter@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH 2/2] x86/acpi: Remove the repeated lapic address override entry parsing

On Tuesday, June 28, 2016 07:41:36 AM Baoquan He wrote:
> ACPI MADT has a 32-bit field providing lapic address at which
> each processor can access its lapic information. MADT also contains
> an optional entry to provide a 64-bit address to override the 32-bit
> one. However the current code does the lapic address override entry
> parsing twice. One is in early_acpi_boot_init() because AMD NUMA need
> get boot_cpu_id earlier. The other is in acpi_boot_init() which parses
> all MADT entries. The relevant log will be printed out twice too and
> this may confuse people.
> 
> So in this patch remove the repeated code in the 2nd part. Meanwhile
> add code comment above early_acpi_boot_init() to explain why its
> calling need be earlier, and print lapic override inforamtion like
> other MADT entry.
> 
> Signed-off-by: Baoquan He <bhe@...hat.com>
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: Len Brown <len.brown@...el.com>
> Cc: Pavel Machek <pavel@....cz>
> Cc: Thomas Gleixner <tglx@...utronix.de> 
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Borislav Petkov <bp@...e.de>
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Shaohua Li <shli@...com>
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> Cc: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>
> Cc: Juergen Gross <jgross@...e.com>
> Cc: Joerg Roedel <jroedel@...e.de>
> Cc: Dave Young <dyoung@...hat.com>
> Cc: Lv Zheng <lv.zheng@...el.com>
> Cc: Toshi Kani <toshi.kani@....com>
> Cc: Mark Salter <msalter@...hat.com>
> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> ---
>  arch/x86/kernel/acpi/boot.c | 17 ++---------------
>  arch/x86/kernel/apic/apic.c |  2 +-
>  arch/x86/kernel/setup.c     |  3 +++
>  3 files changed, 6 insertions(+), 16 deletions(-)
> 
> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> index 9414f84..6ef3694 100644
> --- a/arch/x86/kernel/acpi/boot.c
> +++ b/arch/x86/kernel/acpi/boot.c
> @@ -274,6 +274,8 @@ acpi_parse_lapic_addr_ovr(struct acpi_subtable_header * header,
>  	if (BAD_MADT_ENTRY(lapic_addr_ovr, end))
>  		return -EINVAL;
>  
> +	acpi_table_print_madt_entry(header);
> +
>  	acpi_lapic_addr = lapic_addr_ovr->address;
>  
>  	return 0;
> @@ -990,21 +992,6 @@ static int __init acpi_parse_madt_lapic_entries(void)
>  	if (!boot_cpu_has(X86_FEATURE_APIC))
>  		return -ENODEV;
>  
> -	/*
> -	 * Note that the LAPIC address is obtained from the MADT (32-bit value)
> -	 * and (optionally) overridden by a LAPIC_ADDR_OVR entry (64-bit value).
> -	 */
> -
> -	count = acpi_table_parse_madt(ACPI_MADT_TYPE_LOCAL_APIC_OVERRIDE,
> -				      acpi_parse_lapic_addr_ovr, 0);
> -	if (count < 0) {
> -		printk(KERN_ERR PREFIX
> -		       "Error parsing LAPIC address override entry\n");
> -		return count;
> -	}
> -
> -	register_lapic_address(acpi_lapic_addr);
> -

I'm not really sure if this change is correct.

Does it only deal with the override?

>  	count = acpi_table_parse_madt(ACPI_MADT_TYPE_LOCAL_SAPIC,
>  				      acpi_parse_sapic, MAX_LOCAL_APIC);
>  
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index 60078a6..504311c 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -1799,7 +1799,7 @@ void __init register_lapic_address(unsigned long address)
>  	if (!x2apic_mode) {
>  		set_fixmap_nocache(FIX_APIC_BASE, address);
>  		apic_printk(APIC_VERBOSE, "mapped APIC to %16lx (%16lx)\n",
> -			    APIC_BASE, mp_lapic_addr);
> +			    APIC_BASE, address);
>  	}
>  	if (boot_cpu_physical_apicid == -1U) {
>  		boot_cpu_physical_apicid  = read_apic_id();
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index c4e7b39..059680d 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -1157,6 +1157,9 @@ void __init setup_arch(char **cmdline_p)
>  	 */
>  	acpi_boot_table_init();
>  
> +	/*
> +	 * AMD NUMA support need get boot_cpu_id earlier.
> +	 */

Surely that's not the only goal of early_acpi_boot_init(), is it?

>  	early_acpi_boot_init();
>  
>  	initmem_init();
> 

Please CC ACPI-related patches to linux-acpi@...r.kernel.org.

Thanks,
Rafael