linux-kernel - Re: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160628.053350.1891488485477523405.davem@davemloft.net>
Date:	Tue, 28 Jun 2016 05:33:50 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	decui@...rosoft.com
Cc:	gregkh@...uxfoundation.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	olaf@...fle.de, apw@...onical.com, jasowang@...hat.com,
	vkuznets@...hat.com, cavery@...hat.com, kys@...rosoft.com,
	haiyangz@...rosoft.com, joe@...ches.com
Subject: Re: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets

From: Dexuan Cui <decui@...rosoft.com>
Date: Fri, 24 Jun 2016 07:45:24 +0000

> +	while ((ret = vmalloc(size)) == NULL)
> +		ssleep(1);

This is completely, and entirely, unacceptable.

If the allocation fails, you return an error and release
your resources.

You don't just loop forever waiting for it to succeed.