linux-kernel - Re: arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1467106510.20278.119.camel@kernel.crashing.org>
Date:	Tue, 28 Jun 2016 19:35:10 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	David Binderman <linuxdev.baldrick@...il.com>,
	Michael Ellerman <mpe@...erman.id.au>
Cc:	paulus@...ba.org, linuxppc-dev@...ts.ozlabs.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	dcb314@...mail.com
Subject: Re: arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ?

On Tue, 2016-06-28 at 08:06 +0100, David Binderman wrote:
> 
> I don't know the code, but given that insn is unsigned long and so
> can go
> past 32 bits, using a cast to unsigned int might throw away the
> possibly important
> upper bits.

our instructions are only ever 32-bits. That xmon code is ancient and
originated from 32-bits stuff. In fact some of Paulus earliest xmons
might even have run on platforms where int is 16 bits :-)

Cheers,
Ben.