linux-kernel - Re: [PATCH] drm/i915: fix build errors when ACPI is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878txpshaw.fsf@intel.com>
Date:	Tue, 28 Jun 2016 14:07:19 +0300
From:	Jani Nikula <jani.nikula@...el.com>
To:	Chris Wilson <chris@...is-wilson.co.uk>
Cc:	Randy Dunlap <rdunlap@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-next\@vger.kernel.org" <linux-next@...r.kernel.org>,
	Daniel Vetter <daniel.vetter@...el.com>,
	intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	drm-intel-fixes@...ts.freedesktop.org
Subject: Re: [PATCH] drm/i915: fix build errors when ACPI is not enabled

On Tue, 28 Jun 2016, Chris Wilson <chris@...is-wilson.co.uk> wrote:
> On Mon, Jun 27, 2016 at 02:53:19PM +0300, Jani Nikula wrote:
>> From: Randy Dunlap <rdunlap@...radead.org>
>> 
>> Fix build errors when ACPI is not enabled by adding function stubs:
>> 
>> ../drivers/gpu/drm/i915/i915_drv.c: In function 'i915_drm_suspend':
>> ../drivers/gpu/drm/i915/i915_drv.c:635:2: error: implicit declaration of function 'intel_opregion_unregister' [-Werror=implicit-function-declaration]
>>   intel_opregion_unregister(dev_priv);
>> ../drivers/gpu/drm/i915/i915_drv.c: In function 'i915_drm_resume':
>> ../drivers/gpu/drm/i915/i915_drv.c:798:2: error: implicit declaration of function 'intel_opregion_register' [-Werror=implicit-function-declaration]
>>   intel_opregion_register(dev_priv);
>> 
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Daniel Vetter <daniel.vetter@...el.com>
>> Cc: Jani Nikula <jani.nikula@...ux.intel.com>
>> Cc: intel-gfx@...ts.freedesktop.org
>> Cc: dri-devel@...ts.freedesktop.org
>> Fixes: 03d92e4779b8 ("drm/i915/opregion: Rename init/fini functions to register/unregister")
>> Cc: drm-intel-fixes@...ts.freedesktop.org
>> Cc: Chris Wilson <chris@...is-wilson.co.uk>
>> [Jani: dropped the stale init/fini declarations]
>> Signed-off-by: Jani Nikula <jani.nikula@...el.com>
> Reviewed-by: Chris Wilson <chris@...is-wilson.co.uk>
> -Chris

Pushed to drm-intel-next-queued, thanks for the patch and review.

BR,
Jani.



-- 
Jani Nikula, Intel Open Source Technology Center