[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160628120137.GE24982@dell>
Date: Tue, 28 Jun 2016 13:01:37 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Stefan Agner <stefan@...er.ch>
Cc: lgirdwood@...il.com, broonie@...nel.org, khilman@...libre.com,
carlo@...one.org, b.galvani@...il.com, max.oss.09@...il.com,
marcel@...wiler.com, linux@...linux.org.uk, galak@...eaurora.org,
ijc+devicetree@...lion.org.uk, mark.rutland@....com,
pawel.moll@....com, robh+dt@...nel.org, linux@...ck-us.net,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH v4 4/5] mfd: rn5t618: register power off callback
optionally
On Mon, 27 Jun 2016, Stefan Agner wrote:
> Only register power off if the PMIC is defined as system power
> controller (see Documentation/devicetree/bindings/power/
> power-controller.txt).
>
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> Reviewed-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> ---
> drivers/mfd/rn5t618.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
For my own reference:
Acked-by: Lee Jones <lee.jones@...aro.org>
> diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c
> index c86160d..1831740 100644
> --- a/drivers/mfd/rn5t618.c
> +++ b/drivers/mfd/rn5t618.c
> @@ -102,9 +102,13 @@ static int rn5t618_i2c_probe(struct i2c_client *i2c,
> return ret;
> }
>
> - if (!pm_power_off) {
> - rn5t618_pm_power_off = priv;
> - pm_power_off = rn5t618_power_off;
> + if (of_device_is_system_power_controller(i2c->dev.of_node)) {
> + if (!pm_power_off) {
> + rn5t618_pm_power_off = priv;
> + pm_power_off = rn5t618_power_off;
> + } else {
> + dev_warn(&i2c->dev, "Poweroff callback already assigned\n");
> + }
> }
>
> return 0;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists