linux-kernel - Re: [PATCH] connector: fix out-of-order cn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160628.084919.306629083152756936.davem@davemloft.net>
Date:	Tue, 28 Jun 2016 08:49:19 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	aaron@...key.org
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	zbr@...emap.net, nuxi@...lt24.org
Subject: Re: [PATCH] connector: fix out-of-order cn_proc netlink message
 delivery

From: Aaron Campbell <aaron@...key.org>
Date: Fri, 24 Jun 2016 10:05:32 -0300

> The proc connector messages include a sequence number, allowing userspace
> programs to detect lost messages.  However, performing this detection is
> currently more difficult than necessary, since netlink messages can be
> delivered to the application out-of-order.  To fix this, leave pre-emption
> disabled during cn_netlink_send(), and use GFP_NOWAIT.
> 
> The following was written as a test case.  Building the kernel w/ make -j32
> proved a reliable way to generate out-of-order cn_proc messages.
 ...
> Signed-off-by: Aaron Campbell <aaron@...key.org>

Applied.