linux-kernel - Re: [PATCH] w1: Remove unneeded header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Jun 2016 15:49:50 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Evgeniy Polyakov <zbr@...emap.net>
cc:	Amitoj Kaur Chawla <amitoj1606@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] w1: Remove unneeded header file

On Tue, 28 Jun 2016, Evgeniy Polyakov wrote:

> Hi
>
> 24.06.2016, 09:18, "Amitoj Kaur Chawla" <amitoj1606@...il.com>:
> > Drop redundant include of moduleparam.h
> >
> > The Coccinelle semantic patch used to make this change is as follows:
> > @ includesmodule @
> > @@
> >
> > #include <linux/module.h>
> >
> > @ depends on includesmodule @
> > @@
> >
> > - #include <linux/moduleparam.h>
> >
> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>
>
> Looks good to me, but these @@ are pretty cryptic.

There are two rules.  The first checks for an include of module.h.  The
second depends on the success of the first one.  It removes and include o
moduleparam.h.

julia