linux-kernel - Re: [PATCH 01/23] [AARCH64] define word size for lp64 and ilp32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1606281657540.25214@digraph.polyomino.org.uk>
Date:	Tue, 28 Jun 2016 17:00:28 +0000
From:	Joseph Myers <joseph@...esourcery.com>
To:	Yury Norov <ynorov@...iumnetworks.com>
CC:	<libc-alpha@...rceware.org>, <linux-kernel@...r.kernel.org>,
	<arnd@...db.de>, <catalin.marinas@....com>,
	<marcus.shawcroft@....com>, <philb@....org>, <davem@...emloft.net>,
	<szabolcs.nagy@....com>, <maxim.kuvyrkov@...aro.org>,
	<pinskia@...il.com>, <bamvor.zhangjian@...wei.com>,
	<schwab@...e.de>, <fweimer@...hat.com>, <Prasun.Kapoor@...ium.com>,
	<cmetcalf@...lanox.com>, <hjl.tools@...il.com>,
	<adhemerval.zanella@...aro.org>, Andrew Pinski <apinski@...ium.com>
Subject: Re: [PATCH 01/23] [AARCH64] define word size for lp64 and ilp32

On Tue, 28 Jun 2016, Yury Norov wrote:

> diff --git a/sysdeps/aarch64/bits/wordsize.h b/sysdeps/aarch64/bits/wordsize.h

See what I said in 
<https://sourceware.org/ml/libc-alpha/2016-06/msg00786.html> about "make 
other bits/wordsize.h files define the macro to 0".  This patch would 
break all other architectures (and AArch64 LP64 - you should test build 
and testsuite for that, as well as ILP32, and confirm that there are no 
testsuite regressions for LP64).

> +/* Copyright (C) 2014 Free Software Foundation, Inc.

See what I said in 
<https://sourceware.org/ml/libc-alpha/2016-06/msg00780.html> about 
one-line descriptions before copyright notices.  Please check every new 
file in every patch in the series for this issue.

All copyright notices should have ranges of years that end in 2016.

-- 
Joseph S. Myers
joseph@...esourcery.com