linux-kernel - Re: [PATCH 17/23] [AARCH64] ILP32: introduce syscalls that pass off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1606281711290.25214@digraph.polyomino.org.uk>
Date:	Tue, 28 Jun 2016 17:13:07 +0000
From:	Joseph Myers <joseph@...esourcery.com>
To:	Yury Norov <ynorov@...iumnetworks.com>
CC:	<libc-alpha@...rceware.org>, <linux-kernel@...r.kernel.org>,
	<arnd@...db.de>, <catalin.marinas@....com>,
	<marcus.shawcroft@....com>, <philb@....org>, <davem@...emloft.net>,
	<szabolcs.nagy@....com>, <maxim.kuvyrkov@...aro.org>,
	<pinskia@...il.com>, <bamvor.zhangjian@...wei.com>,
	<schwab@...e.de>, <fweimer@...hat.com>, <Prasun.Kapoor@...ium.com>,
	<cmetcalf@...lanox.com>, <hjl.tools@...il.com>,
	<adhemerval.zanella@...aro.org>, Yury Norov <yury.norov@...il.com>
Subject: Re: [PATCH 17/23] [AARCH64] ILP32: introduce syscalls that pass
 off_t

On Tue, 28 Jun 2016, Yury Norov wrote:

> ILP32 has 64-bit off_t, to follow modern requirements.
> But kernel clears top-halves of input registers. It means
> we have to pass corresponding arguments in a pair, like
> aarch32 does. In this patch all affected syscalls are redefined.
> Most of them are taken from arm code.

Please follow the spirit of Adhemerval's recent work.  Determine the 
appropriate abstractions for the architecture differences for these 
syscalls, and set up unified implementations used on all architectures, 
rather than increasing the number of architecture-specific variants.

> +#ifdef __ILP32__
> +/* Define this if your 32-bit syscall API requires 64-bit register
> +   pairs to start with an even-number register.  */
> +#define __ASSUME_ALIGNED_REGISTER_PAIRS	1
> +#endif /* __ILP32__ */

Preprocessor indentation.

-- 
Joseph S. Myers
joseph@...esourcery.com