linux-kernel - Re: [PATCH 10/23] [AARCH64] Detect ILP32 in configure scripts.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160628171320.GA1670@yury-N73SV>
Date:	Tue, 28 Jun 2016 20:26:38 +0300
From:	Yury Norov <ynorov@...iumnetworks.com>
To:	Joseph Myers <joseph@...esourcery.com>
CC:	<libc-alpha@...rceware.org>, <linux-kernel@...r.kernel.org>,
	<arnd@...db.de>, <catalin.marinas@....com>,
	<marcus.shawcroft@....com>, <philb@....org>, <davem@...emloft.net>,
	<szabolcs.nagy@....com>, <maxim.kuvyrkov@...aro.org>,
	<pinskia@...il.com>, <bamvor.zhangjian@...wei.com>,
	<schwab@...e.de>, <fweimer@...hat.com>, <Prasun.Kapoor@...ium.com>,
	<cmetcalf@...lanox.com>, <hjl.tools@...il.com>,
	<adhemerval.zanella@...aro.org>, Andrew Pinski <apinski@...ium.com>
Subject: Re: [PATCH 10/23] [AARCH64] Detect ILP32 in configure scripts.

On Tue, Jun 28, 2016 at 05:07:49PM +0000, Joseph Myers wrote:
> <https://sourceware.org/ml/libc-alpha/2016-06/msg00785.html> and 
> <https://sourceware.org/ml/libc-alpha/2014-10/msg00639.html> still apply.  
> Please make the changes requested there before any reposting of the patch 
> series.

Yes, I forgot about glibc version. I don't want to add changelogs
because I think patches order should/may be changed, and as all that
changelogs touch single file, there will be nightmare to rebase
series.

>> diff --git a/sysdeps/aarch64/preconfigure
>> b/sysdeps/aarch64/preconfigure
>> index d9bd1f8..4bcd8e3 100644
>> --- a/sysdeps/aarch64/preconfigure
>> +++ b/sysdeps/aarch64/preconfigure
>> @@ -1,6 +1,15 @@
>>  case "$machine" in
>>  aarch64*)
>>       base_machine=aarch64
>> -     machine=aarch64
>> +     case "$CC $CFLAGS $CPPFLAGS " in
>> +             *" -mabi=ilp32 "*) aarch64_config_abi=ilp32 ;;
>> +             *" -mabi=lp64 "*) aarch64_config_abi=lp64 ;;
>> +             *) aarch64_config_abi=default ;;
>> +     esac
>> +     case $aarch64_config_abi in
>> +             default) machine=aarch64/lp64 aarch64_config_abi=lp64
>> ;;
> 
> It would seem better to test how the compiler behaves (what it 
> predefines), as now done for MIPS, so that this works with a compiler 
> configured --with-abi=ilp32 without needing to add an explicit ABI
> option 
> to CC or CFLAGS.

I didn't understand what you mean here and forgot to ask.
I didn't work much on glibc, and not familiar to it's build
system. Could you explain it little more detailed please?