linux-kernel - Re: [PATCH 01/23] [AARCH64] define word size for lp64 and ilp32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Jun 2016 17:30:52 +0000
From:	Joseph Myers <joseph@...esourcery.com>
To:	Yury Norov <ynorov@...iumnetworks.com>
CC:	<libc-alpha@...rceware.org>, <linux-kernel@...r.kernel.org>,
	<arnd@...db.de>, <catalin.marinas@....com>,
	<marcus.shawcroft@....com>, <philb@....org>, <davem@...emloft.net>,
	<szabolcs.nagy@....com>, <maxim.kuvyrkov@...aro.org>,
	<pinskia@...il.com>, <bamvor.zhangjian@...wei.com>,
	<schwab@...e.de>, <fweimer@...hat.com>, <Prasun.Kapoor@...ium.com>,
	<cmetcalf@...lanox.com>, <hjl.tools@...il.com>,
	<adhemerval.zanella@...aro.org>, Andrew Pinski <apinski@...ium.com>
Subject: Re: [PATCH 01/23] [AARCH64] define word size for lp64 and ilp32

On Tue, 28 Jun 2016, Joseph Myers wrote:

> On Tue, 28 Jun 2016, Yury Norov wrote:
> 
> > diff --git a/sysdeps/aarch64/bits/wordsize.h b/sysdeps/aarch64/bits/wordsize.h
> 
> See what I said in 
> <https://sourceware.org/ml/libc-alpha/2016-06/msg00786.html> about "make 
> other bits/wordsize.h files define the macro to 0".  This patch would 
> break all other architectures (and AArch64 LP64 - you should test build 
> and testsuite for that, as well as ILP32, and confirm that there are no 
> testsuite regressions for LP64).

(Actually, for LP64, if you can confirm that the installed stripped shared 
libraries are byte-for-byte identical before and after the patch series, 
then a testsuite run is unnecessary.  But you still need to run the 
testsuite for ILP32, and justify any failures there, and if the LP64 
binaries aren't byte-for-byte identical, you should justify why they 
aren't.)

-- 
Joseph S. Myers
joseph@...esourcery.com