[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5772BF7A.3020700@hisilicon.com>
Date: Tue, 28 Jun 2016 19:18:34 +0100
From: Wei Xu <xuwei5@...ilicon.com>
To: John Stultz <john.stultz@...aro.org>,
lkml <linux-kernel@...r.kernel.org>
CC: Zhangfei Gao <zhangfei.gao@...aro.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...eaurora.org>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Guodong Xu <guodong.xu@...aro.org>, <xuwei5@...ilicon.com>
Subject: Re: [RESEND][PATCH 2/2] arm64: dts: hi6220: Add pl031 RTC support
Hi John,
On 23/06/2016 21:39, John Stultz wrote:
> From: Zhangfei Gao <zhangfei.gao@...aro.org>
>
> Add pl031 rtc0 and rtc1 support to hi6220 dtsi
>
> Cc: Michael Turquette <mturquette@...libre.com>
> Cc: Stephen Boyd <sboyd@...eaurora.org>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Pawel Moll <pawel.moll@....com>
> Cc: Wei Xu <xuwei5@...ilicon.com>
> Cc: Guodong Xu <guodong.xu@...aro.org>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@...aro.org>
> [jstultz: Forward ported and tweaked commit description,
> added rtc1 entry as suggested by Guodong]
> Signed-off-by: John Stultz <john.stultz@...aro.org>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 189d215..12510b5 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -336,6 +336,22 @@
> clock-names = "timer1", "timer2", "apb_pclk";
> };
>
> + rtc0: rtc@...03000 {
> + compatible = "arm,pl031", "arm,primecell";
> + reg = <0x0 0xf8003000 0x0 0x1000>;
> + interrupts = <0 12 4>;
> + clocks = <&ao_ctrl HI6220_RTC0_PCLK>;
> + clock-names = "apb_pclk";
> + };
> +
> + rtc1: rtc@...04000 {
Sorry for the late reply.
Thanks for the patch!
Except the indent of the rtc1, the others is fine to me.
Acked-by: Wei Xu <xuwei5@...ilicon.com>
As what Stephen said in the cover letter works for me.
Best Regards,
Wei
> + compatible = "arm,pl031", "arm,primecell";
> + reg = <0x0 0xf8004000 0x0 0x1000>;
> + interrupts = <0 8 4>;
> + clocks = <&ao_ctrl HI6220_RTC1_PCLK>;
> + clock-names = "apb_pclk";
> + };
> +
> pmx0: pinmux@...10000 {
> compatible = "pinctrl-single";
> reg = <0x0 0xf7010000 0x0 0x27c>;
>
Powered by blists - more mailing lists