linux-kernel - Re: [PATCH 18/23] [AARCH64] ILP32: support stat syscall family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160628185102.GA2592@yury-N73SV>
Date:	Tue, 28 Jun 2016 22:08:19 +0300
From:	Yury Norov <ynorov@...iumnetworks.com>
To:	Joseph Myers <joseph@...esourcery.com>
CC:	<libc-alpha@...rceware.org>, <linux-kernel@...r.kernel.org>,
	<arnd@...db.de>, <catalin.marinas@....com>,
	<marcus.shawcroft@....com>, <philb@....org>, <davem@...emloft.net>,
	<szabolcs.nagy@....com>, <maxim.kuvyrkov@...aro.org>,
	<pinskia@...il.com>, <bamvor.zhangjian@...wei.com>,
	<schwab@...e.de>, <fweimer@...hat.com>, <Prasun.Kapoor@...ium.com>,
	<cmetcalf@...lanox.com>, <hjl.tools@...il.com>,
	<adhemerval.zanella@...aro.org>, Yury Norov <yury.norov@...il.com>
Subject: Re: [PATCH 18/23] [AARCH64] ILP32: support stat syscall family

On Tue, Jun 28, 2016 at 05:15:13PM +0000, Joseph Myers wrote:
> <https://sourceware.org/ml/libc-alpha/2016-06/msg00791.html> still 
> applies.  Unify implementations instead of proliferating variants.

I think on it. I don't see simple way to unify it right now. And I
plan to take a vacation in next two weeks, so I'd like to share my 
progress to community (mostly for kernel), as this series has some
LTP tests fixed, and this is important for us.

What you talk about sounds unclear to me. If you mean to unify with
one of existing ports, it looks unnecessary, as ilp32 will end up with 
RISC-V anyway. If you mean to use RISC-V, it's not ready yet. I was
thinking that when they will finish, they simply switch this port to
their code. Am I too optimistic?

> Also, much of the formatting is way off the GNU Coding Standards (e.g. 
> indentation that's not two-column, "{" not on a line by itself), and 
> you're missing descriptions as first lines of many new files.

Is there glibc analogue for kernel scripts/checkpatch.pl? If yes,
please point me out, and I'll briefly fix all issues. If no please be
patient to whitespace rules violations. I completely understand the
importance of following the coding rules, but now I am little limited
in time and prefer to fix real bugs first, and then read that document
carefully and check all the mess I introduced.

Yury