linux-kernel - Re: [PATCH] phy: xgene: rename "enum phy_mode" to "enum xgene_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 28 Jun 2016 12:57:29 -0700
From:	Loc Ho <lho@....com>
To:	Kishon Vijay Abraham I <kishon@...com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	david@...hnology.com
Subject: Re: [PATCH] phy: xgene: rename "enum phy_mode" to "enum xgene_phy_mode"

Hi,

> commit 96284c53246f ("phy: Add set_mode callback") introduced
> enum phy_mode in phy_core. This introduced the following build
> error.
>
> drivers/phy/phy-xgene.c:521:6: error: nested redefinition of 'enum phy_mode'
>  enum phy_mode {
>       ^
> drivers/phy/phy-xgene.c:521:6: error: redeclaration of 'enum phy_mode'
> In file included from drivers/phy/phy-xgene.c:57:0:
> include/linux/phy/phy.h:25:6: note: originally defined here
>  enum phy_mode {
>       ^
> Fix it here.
>
> Fixes: 96284c53246f ("phy: Add set_mode callback")
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>

You can add my:

Reviewed-by: Loc Ho <lho@....com>

-Loc