linux-kernel - Re: [PATCH] Drivers: block: fixed a code style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201606290326.Jilkxa2u%fengguang.wu@intel.com>
Date:	Wed, 29 Jun 2016 03:54:55 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Saidgani Musaev <cpu808694@...il.com>
Cc:	kbuild-all@...org, ming.lei@...onical.com,
	linux-kernel@...r.kernel.org, Saidgani Musaev <cpu808694@...il.com>
Subject: Re: [PATCH] Drivers: block: fixed a code style issue

Hi,

[auto build test WARNING on v4.7-rc5]
[also build test WARNING on next-20160628]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Saidgani-Musaev/Drivers-block-fixed-a-code-style-issue/20160629-025927
config: mips-jz4740 (attached as .config)
compiler: mips-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=mips 

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/posix_types.h:4:0,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/linux/list.h:4,
                    from include/linux/module.h:9,
                    from drivers/block/loop.c:52:
   drivers/block/loop.c: In function 'max_loop_setup':
>> include/linux/stddef.h:7:14: warning: passing argument 2 of 'kstrtol' makes integer from pointer without a cast [-Wint-conversion]
    #define NULL ((void *)0)
                 ^
>> drivers/block/loop.c:2055:26: note: in expansion of macro 'NULL'
     max_loop = kstrtol(str, NULL, 0);
                             ^
   In file included from include/linux/list.h:8:0,
                    from include/linux/module.h:9,
                    from drivers/block/loop.c:52:
   include/linux/kernel.h:327:32: note: expected 'unsigned int' but argument is of type 'void *'
    static inline int __must_check kstrtol(const char *s, unsigned int base, long *res)
                                   ^

vim +/NULL +2055 drivers/block/loop.c

  2039	
  2040		idr_for_each(&loop_index_idr, &loop_exit_cb, NULL);
  2041		idr_destroy(&loop_index_idr);
  2042	
  2043		blk_unregister_region(MKDEV(LOOP_MAJOR, 0), range);
  2044		unregister_blkdev(LOOP_MAJOR, "loop");
  2045	
  2046		misc_deregister(&loop_misc);
  2047	}
  2048	
  2049	module_init(loop_init);
  2050	module_exit(loop_exit);
  2051	
  2052	#ifndef MODULE
  2053	static int __init max_loop_setup(char *str)
  2054	{
> 2055		max_loop = kstrtol(str, NULL, 0);
  2056		return 1;
  2057	}
  2058	
  2059	__setup("max_loop=", max_loop_setup);
  2060	#endif

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (18825 bytes)