linux-kernel - Re: [PATCH] platform:x86 Remove Monitor MWAIT feature dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160628202353.GJ3837@f23x64.localdomain>
Date:	Tue, 28 Jun 2016 13:23:53 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	ong.hock.yu@...el.com
Cc:	souvik.k.chakravarty@...el.com,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform:x86 Remove Monitor MWAIT feature dependency

On Thu, Jun 23, 2016 at 02:59:58PM +0800, ong.hock.yu@...el.com wrote:
> From: "Yu, Ong Hock" <ong.hock.yu@...el.com>
> 
> Telemetry capability does not depend on Monitor MWAIT feature.
> 
> Signed-off-by: Yu, Ong Hock <ong.hock.yu@...el.com>

Souvik, any objection?

> ---
>  drivers/platform/x86/intel_telemetry_debugfs.c | 2 +-
>  drivers/platform/x86/intel_telemetry_pltdrv.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c b/drivers/platform/x86/intel_telemetry_debugfs.c
> index f5134ac..d76ee59 100644
> --- a/drivers/platform/x86/intel_telemetry_debugfs.c
> +++ b/drivers/platform/x86/intel_telemetry_debugfs.c
> @@ -78,7 +78,7 @@
>  #define TELEM_EVT_LEN(x) (sizeof(x)/sizeof((x)[0]))
>  
>  #define TELEM_DEBUGFS_CPU(model, data) \
> -	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&data}
> +	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data}
>  
>  #define TELEM_CHECK_AND_PARSE_EVTS(EVTID, EVTNUM, BUF, EVTLOG, EVTDAT, MASK) { \
>  	if (evtlog[index].telem_evtid == (EVTID)) { \
> diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
> index 09c84a2..e62cee9 100644
> --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> @@ -82,7 +82,7 @@
>  #define TELEM_SET_VERBOSITY_BITS(x, y)	((x) |= ((y) << 27))
>  
>  #define TELEM_CPU(model, data) \
> -	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&data }
> +	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data }
>  
>  enum telemetry_action {
>  	TELEM_UPDATE = 0,
> -- 
> 1.9.1
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center