linux-kernel - Re: [PATCH] KVM: vmx: fix underflow in TSC deadline calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANRm+CyL+RbVoh4XXCU0FTgaa1QdkL5snJqybYV8bPM3uNFtXg@mail.gmail.com>
Date:	Wed, 29 Jun 2016 08:39:35 +0800
From:	Wanpeng Li <kernellwp@...il.com>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	yunhong jiang <yunhong.jiang@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	kvm <kvm@...r.kernel.org>, Wanpeng Li <wanpeng.li@...mail.com>,
	Radim Krčmář <rkrcmar@...hat.com>,
	Yunhong Jiang <yunhong.jiang@...el.com>
Subject: Re: [PATCH] KVM: vmx: fix underflow in TSC deadline calculation

2016-06-29 6:55 GMT+08:00 Wanpeng Li <kernellwp@...il.com>:
> 2016-06-29 4:07 GMT+08:00 Paolo Bonzini <pbonzini@...hat.com>:
>>
>>
>> On 28/06/2016 20:34, yunhong jiang wrote:
>>> Paolo, thanks for reply.
>>>
>>> Which race window you are talking about? Is it the
>>> kvm_lapic_switch_to_hv_timer()? If yes, hope we will not forgot it once the
>>> lapic timer is not pinned anymore in future.
>>
>> Yes, it's that one.  This is a good point against using
>> local_irq_save/restore.
>>
>> Paolo
>
> How about something like below(untested, just want to know if this is
> what you mean):

It can also fix the bug after my testing, I can send out a formal one
if it looks good to you.

Regards,
Wanpeng Li