linux-kernel - Re: [PATCH 19/23] [AARCH64] delouse input arguments in system functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mvmlh1oigdm.fsf@hawking.suse.de>
Date:	Wed, 29 Jun 2016 09:49:41 +0200
From:	Andreas Schwab <schwab@...e.de>
To:	Yury Norov <ynorov@...iumnetworks.com>
Cc:	<libc-alpha@...rceware.org>, <linux-kernel@...r.kernel.org>,
	<arnd@...db.de>, <catalin.marinas@....com>,
	<marcus.shawcroft@....com>, <philb@....org>, <davem@...emloft.net>,
	<szabolcs.nagy@....com>, <maxim.kuvyrkov@...aro.org>,
	<joseph@...esourcery.com>, <pinskia@...il.com>,
	<bamvor.zhangjian@...wei.com>, <fweimer@...hat.com>,
	<Prasun.Kapoor@...ium.com>, <cmetcalf@...lanox.com>,
	<hjl.tools@...il.com>, <adhemerval.zanella@...aro.org>
Subject: Re: [PATCH 19/23] [AARCH64] delouse input arguments in system functions

Yury Norov <ynorov@...iumnetworks.com> writes:

> @@ -174,6 +177,7 @@ _dl_tlsdesc_dynamic:
>  	stp	x29, x30, [sp,#-(32+16*NSAVEXREGPAIRS)]!
>  	cfi_adjust_cfa_offset (32+16*NSAVEXREGPAIRS)
>  	mov	x29, sp
> +	DELOUSE(0)
>  
>  	/* Save just enough registers to support fast path, if we fall
>  	   into slow path we will save additional registers.  */
> @@ -188,6 +192,7 @@ _dl_tlsdesc_dynamic:
>  	   td->entry) and thus it synchronizes with the release store to
>  	   td->entry in _dl_tlsdesc_resolve_rela_fixup ensuring that the load
>  	   from [x0,#PTR_SIZE] here happens after the initialization of td->arg.  */
> +	DELOUSE(0)

Once is enough.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@...e.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."