linux-kernel - Re: [PATCH v5 0/5] regulator: add Ricoh RN5T567 PMIC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c82c2ab2fecc805746cb719db5e34723@agner.ch>
Date:	Wed, 29 Jun 2016 01:15:36 -0700
From:	Stefan Agner <stefan@...er.ch>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	lgirdwood@...il.com, broonie@...nel.org, khilman@...libre.com,
	carlo@...one.org, b.galvani@...il.com, max.oss.09@...il.com,
	marcel@...wiler.com, linux@...linux.org.uk, galak@...eaurora.org,
	ijc+devicetree@...lion.org.uk, mark.rutland@....com,
	pawel.moll@....com, robh+dt@...nel.org, linux@...ck-us.net,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH v5 0/5] regulator: add Ricoh RN5T567 PMIC support

On 2016-06-29 01:12, Lee Jones wrote:
> On Tue, 28 Jun 2016, Stefan Agner wrote:
> 
>> This patchset adds RN5T567 PMIC support which is used on the
>> Toradex Colibri iMX7S/iMX7D modules. The existing RN5T618 is from
>> the same family, hence this patchset uses the same driver and adds
>> variant support.
>>
>> The Colibris currently do not use the PMIC's power off capabilities,
>> as do the current users of that PMIC driver. Therefore this patchset
>> also makes the use of the system-power-controller property mandatory
>> if the power off capabilties are required.
>>
>> Changes since v4:
>> - Spell check in patch 5 and added Acks
>>
>> Changes since v3:
>> - Use RN5T618_REPCNT_REPWRON macro when writing RN5T618_REPCNT register
>>
>> Changes since v2:
>> - Elevate restart priority to 192 to make sure PMIC takes presedence
>>   over SoC level restart capabilities (e.g. watchdog)
>> - Print a warning if poweroff callback is already assigned
>> - Reorder of_id and variant assignment
>> - Lower delay to 1ms and justify why it is required
>> - Fix DCDC count and a typos in device tree bindings
>>
>> Changes since v1:
>> - Removed obsolete include <asm/system_misc.h>
>>
>> Stefan Agner (5):
>>   ARM: dts: meson: minix-neo-x8: define PMIC as power controller
>>   mfd: add Ricoh RN5T567 PMIC support
>>   regulator: rn5t618: add RN5T567 PMIC support
>>   mfd: rn5t618: register power off callback optionally
>>   mfd: rn5t618: register restart handler
>>
>>  Documentation/devicetree/bindings/mfd/rn5t618.txt | 19 +++---
>>  arch/arm/boot/dts/meson8-minix-neo-x8.dts         |  1 +
>>  drivers/mfd/Kconfig                               |  7 ++-
>>  drivers/mfd/rn5t618.c                             | 70 +++++++++++++++++++----
>>  drivers/regulator/Kconfig                         |  5 +-
>>  drivers/regulator/rn5t618-regulator.c             | 40 +++++++++++--
>>  include/linux/mfd/rn5t618.h                       | 13 +++++
>>  7 files changed, 126 insertions(+), 29 deletions(-)
> 
> Looks like you have all your Acks now.  How do you want to play this?
> Would you like me to take the set through MFD and provide the other
> Maintainers with a branch to pull from, or did you have other ideas?

I did not thought about that really, I guess you have a usual way for
mixed regulator/mfd patchsets? Taking it through MFD sounds good to
me...

--
Stefan