linux-kernel - Re: [PATCH 0/4] ftrace: One more check on x86 and some small fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 29 Jun 2016 10:22:49 +0200
From:	Petr Mladek <pmladek@...e.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Ingo Molnar <mingo@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Jiri Kosina <jkosina@...e.cz>, linux-kernel@...r.kernel.org,
	x86@...nel.org
Subject: Re: [PATCH 0/4] ftrace: One more check on x86 and some small fixes

On Tue 2016-06-28 15:17:56, Steven Rostedt wrote:
> On Mon, 27 Jun 2016 15:54:33 +0200
> Petr Mladek <pmladek@...e.com> wrote:
> 
> > 1st patch adds one more paranoid check of the modified function on x86.
> > 
> > Plus there are 3 small changes that appeared when hunting down
> > the 1st patch.
> > 
> > Petr Mladek (4):
> >   ftrace/x86: Make sure to modify 5-bite instructions
> >   ftrace/x86: Do not crash when reading wrong ftrace func
> 
> The first two are mostly just "detect error, when it happens again"
> chanes.

Yup.

> >   ftrace: Always destroy trampoline when shutting down the trace
> >   ftrace: Fixup trace_selftest_ops()
> 
> These two seem to fix real bugs. I'm thinking they should go in now and
> be backported via stable.
> 
> Thoughts?

Makes sense. Should I do anything, please?

Best Regards,
Petr