linux-kernel - Re: [PATCH V5 2/3] powerpc/opal: Add inline function to get rc from an ASYNC_COMP opal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <87shvw1hz6.fsf@linux.vnet.ibm.com>
Date:	Wed, 29 Jun 2016 19:07:09 +1000
From:	Stewart Smith <stewart@...ux.vnet.ibm.com>
To:	Suraj Jitindar Singh <sjitindarsingh@...il.com>,
	linuxppc-dev@...ts.ozlabs.org, mpe@...erman.id.au
Cc:	robh@...nel.org, arnd@...db.de, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, paulus@...ba.org,
	sjitindarsingh@...il.com
Subject: Re: [PATCH V5 2/3] powerpc/opal: Add inline function to get rc from an ASYNC_COMP opal_msg

Suraj Jitindar Singh <sjitindarsingh@...il.com> writes:
> --- a/arch/powerpc/include/asm/opal.h
> +++ b/arch/powerpc/include/asm/opal.h
> @@ -276,6 +276,14 @@ extern int opal_error_code(int rc);
>  
>  ssize_t opal_msglog_copy(char *to, loff_t pos, size_t count);
>  
> +static inline int opal_get_async_rc(struct opal_msg msg)
> +{
> +	if (msg.msg_type != OPAL_MSG_ASYNC_COMP)
> +		return OPAL_PARAMETER;

Should instead be WARN_ON or BUG_ON ? Is there *ever* a situation where
calling opal_get_async_rc on a non-OPAL_MSG_ASYNC_COMP is a not both a
dumb idea and a bug?

otherwise (including if above change is made)
Acked-by: Stewart Smith <stewart@...ux.vnet.ibm.com>


-- 
Stewart Smith
OPAL Architect, IBM.