linux-kernel - Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKDJKT4yNAO6OdYTtWQ3W-aNvvFb46p8=g02grvz07af-jTjyw@mail.gmail.com>
Date:	Wed, 29 Jun 2016 16:15:22 +0530
From:	Manish Badarkhe <badarkhe.manish@...il.com>
To:	Keerthy <j-keerthy@...com>
Cc:	linus.walleij@...aro.org, gnurou@...il.com,
	Lee Jones <lee.jones@...aro.org>, linux-omap@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	linux-gpio@...r.kernel.org, Mark Brown <broonie@...nel.org>,
	robh+dt@...nel.org, Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs

Hi Keerthy,

sorry ignore my last two comments in previous mail.

On Wed, Jun 29, 2016 at 4:13 PM, Manish Badarkhe
<badarkhe.manish@...il.com> wrote:
> Hi Keerthy
>
> Some minor comment
>
>> +static int lp873x_gpio_direction_output(struct gpio_chip *chip,
>> +                                       unsigned int offset, int value)
>> +{
>> +       struct lp873x_gpio *gpio = gpiochip_get_data(chip);
>> +
>> +       /* Set the initial value */
>> +       regmap_update_bits(gpio->lp873->regmap, LP873X_REG_GPO_CTRL,
>> +                          BIT(offset * 4), value ? BIT(offset * 4) : 0);
>> +
>> +       return 0;
>> +}

 Error needs to be return, this function always return 0.

 Regards
 Manish Badarkhe