linux-kernel - Re: [BUG] perf test 29 crashing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160629022006.GC1628@sejong>
Date:	Wed, 29 Jun 2016 11:20:06 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	David Ahern <dsahern@...il.com>
CC:	Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>,
	Jiri Olsa <jolsa@...hat.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [BUG] perf test 29 crashing

Hi,

On Tue, Jun 28, 2016 at 11:52:09AM -0600, David Ahern wrote:
> On 6/28/16 10:59 AM, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jun 28, 2016 at 02:34:10PM +0200, Jiri Olsa escreveu:
> > > hi,
> > > I'm having test 29 crashing on latest Arnaldo's perf/core:
> > > 
> > > [jolsa@...va perf]$ ./perf test hist
> > > 15: Test matching and linking multiple hists                 : Ok
> > > 25: Test filtering hist entries                              : Ok
> > > 28: Test output sorting of hist entries                      : Ok
> > > 29: Test cumulation of child hist entries                    : FAILED!
> > > 
> > > I was hunting this, because I though it was caused by one
> > > of my local changes, but then realized it's public bug ;-)
> > > 
> > > but can't find the reason so far..
> > 
> > Huh?
> > 
> > [acme@...et linux]$ perf test 29
> > 29: Test cumulation of child hist entries                    : Ok
> > [acme@...et linux]$ perf --version
> > perf version 4.7.rc5.g1c1e35c
> > [acme@...et linux]$
> > 
> 
> If this helps break the tie:
> 
> dsa@...ny:~/kernel.git$ /tmp/perf/perf test 29
> 29: Test cumulation of child hist entries                    : Ok
> 
> dsa@...ny:~/kernel.git$ /tmp/perf/perf --version
> perf version 4.7.rc5.g02184c
> 
> But running on net-next kernel from a few days ago + 1 local patch:
> dsa@...ny:~/kernel.git$ uname -r
> 4.7.0-rc2-00862-g23854048c919
> 
> (I do get a few other failures)

Running latest acme/perf/core:

  $ perf test hist
  15: Test matching and linking multiple hists                 : Ok
  25: Test filtering hist entries                              : Ok
  28: Test output sorting of hist entries                      : Ok
  29: Test cumulation of child hist entries                    : Ok
  $ perf --version
  perf version 4.6.g6d9c67


But I saw a build failure which was fixed by below patch:

>From 0b011dbf5ba60f78dd3198dc3f72005334507eb4 Mon Sep 17 00:00:00 2001
From: Namhyung Kim <namhyung@...nel.org>
Date: Wed, 29 Jun 2016 11:10:22 +0900
Subject: [PATCH] perf tools: Fix build failture on perl script context
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

    CC       scripts/perl/Perf-Trace-Util/Context.o
  In file included from /usr/lib/perl5/core_perl/CORE/perl.h:3905:0,
                   from Context.xs:23:
  /usr/lib/perl5/core_perl/CORE/inline.h: In function ‘S_cx_popsub_args’:
  /usr/lib/perl5/core_perl/CORE/cop.h:612:13: warning: declaration of ‘av'
                                  shadows a previous local [-Werror=shadow]
             AV *av = GvAV(PL_defgv);
                 ^
  /usr/lib/perl5/core_perl/CORE/inline.h:526:5: note: in expansion of
                                  macro ‘CX_POP_SAVEARRAY’
         CX_POP_SAVEARRAY(cx);
         ^~~~~~~~~~~~~~~~
  In file included from /usr/lib/perl5/core_perl/CORE/perl.h:5853:0,
                   from Context.xs:23:
  /usr/lib/perl5/core_perl/CORE/inline.h:518:9: note:
                                  shadowed declaration is here
         AV *av;
             ^~

Signed-off-by: Namhyung Kim <namhyung@...nel.org>
---
 tools/perf/scripts/perl/Perf-Trace-Util/Build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/perf/scripts/perl/Perf-Trace-Util/Build b/tools/perf/scripts/perl/Perf-Trace-Util/Build
index 928e110179cb..34faecf774ae 100644
--- a/tools/perf/scripts/perl/Perf-Trace-Util/Build
+++ b/tools/perf/scripts/perl/Perf-Trace-Util/Build
@@ -1,3 +1,5 @@
 libperf-y += Context.o
 
-CFLAGS_Context.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-nested-externs -Wno-undef -Wno-switch-default
+CFLAGS_Context.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes
+CFLAGS_Context.o += -Wno-unused-parameter -Wno-nested-externs -Wno-undef
+CFLAGS_Context.o += -Wno-switch-default -Wno-shadow
-- 
2.9.0