linux-kernel - [PATCH] power: qcom-smbb: add extcon dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Jun 2016 16:30:02 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Courtney Cavin <courtney.cavin@...ymobile.com>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] power: qcom-smbb: add extcon dependency

Building the smbb driver without extcon results in a link failure:

drivers/power/built-in.o: In function `smbb_usb_valid_handler':
:(.text+0x3190): undefined reference to `extcon_set_cable_state_'
drivers/power/built-in.o: In function `smbb_charger_probe':
:(.text+0x3880): undefined reference to `devm_extcon_dev_allocate'
:(.text+0x3898): undefined reference to `devm_extcon_dev_register'

This adds a Kconfig dependency.

Signed-off-by: Arnd Bergmann <arnd@...db.de>
Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver")
---
 drivers/power/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
index 0f11a0f4c369..acd4a1524a1e 100644
--- a/drivers/power/Kconfig
+++ b/drivers/power/Kconfig
@@ -394,6 +394,7 @@ config CHARGER_QCOM_SMBB
 	tristate "Qualcomm Switch-Mode Battery Charger and Boost"
 	depends on MFD_SPMI_PMIC || COMPILE_TEST
 	depends on OF
+	depends on EXTCON
 	help
 	  Say Y to include support for the Switch-Mode Battery Charger and
 	  Boost (SMBB) hardware found in Qualcomm PM8941 PMICs.  The charger
-- 
2.9.0