linux-kernel - Re: [PATCH] btrfs: Handle uninitialised inode eviction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <107fec56-cd51-257d-771b-5aa00bd0ebb1@fb.com>
Date:	Wed, 29 Jun 2016 10:00:23 -0400
From:	Josef Bacik <jbacik@...com>
To:	Nikolay Borisov <kernel@...p.com>, <clm@...com>, <dsterba@...e.com>
CC:	<linux-btrfs@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<operations@...eground.com>
Subject: Re: [PATCH] btrfs: Handle uninitialised inode eviction

On 06/29/2016 02:46 AM, Nikolay Borisov wrote:
> The code flow in btrfs_new_inode allows for btrfs_evict_inode to be
> called with not fully initialised inode (e.g. ->root member not
> being set). This can happen when btrfs_set_inode_index in
> btrfs_new_inode fails, which in turn would call iput for the newly
> allocated inode. This in turn leads to vfs calling into btrfs_evict_inode.
> This leads to null pointer dereference. To handle this situation check whether
> the passed inode has root set and just free it in case it doesn't.
>
> Signed-off-by: Nikolay Borisov <kernel@...p.com>

Reviewed-by: Josef Bacik <jbacik@...com>

Thanks,

Josef