linux-kernel - Re: [PATCH] ASoC: cs35l33: mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D39949B3.15144%Paul.Handrigan@cirrus.com>
Date:	Wed, 29 Jun 2016 14:48:15 +0000
From:	"Handrigan, Paul" <Paul.Handrigan@...rus.com>
To:	Arnd Bergmann <arnd@...db.de>, Mark Brown <broonie@...nel.org>
CC:	"Austin, Brian" <Brian.Austin@...rus.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Axel Lin <axel.lin@...ics.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: cs35l33: mark PM functions as __maybe_unused



On 6/29/16, 9:33 AM, "Arnd Bergmann" <arnd@...db.de> wrote:

>The newly added cs35l33 driver produces a harmless warning when
>CONFIG_PM is disabled:
>
>sound/soc/codecs/cs35l33.c:908:12: error: 'cs35l33_runtime_suspend'
>defined but not used [-Werror=unused-function]
>sound/soc/codecs/cs35l33.c:868:12: error: 'cs35l33_runtime_resume'
>defined but not used [-Werror=unused-function]
>
>This adds __maybe_unused annotations to shut up the warning
>regardless of the configuration.
>
>Signed-off-by: Arnd Bergmann <arnd@...db.de>
>---
> sound/soc/codecs/cs35l33.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c
>index 622a1111b21c..d8b5fc3fc45d 100644
>--- a/sound/soc/codecs/cs35l33.c
>+++ b/sound/soc/codecs/cs35l33.c
>@@ -862,7 +862,7 @@ static const struct regmap_config cs35l33_regmap = {
> 	.use_single_rw = true,
> };
> 
>-static int cs35l33_runtime_resume(struct device *dev)
>+static int __maybe_unused cs35l33_runtime_resume(struct device *dev)
> {
> 	struct cs35l33_private *cs35l33 = dev_get_drvdata(dev);
> 	int ret;
>@@ -902,7 +902,7 @@ err:
> 	return ret;
> }
> 
>-static int cs35l33_runtime_suspend(struct device *dev)
>+static int __maybe_unused cs35l33_runtime_suspend(struct device *dev)
> {
> 	struct cs35l33_private *cs35l33 = dev_get_drvdata(dev);
> 
>-- 
>2.9.0

Thanks!

Acked-by: Paul Handrigan <Paul.Handrigan@...rus.com>